Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial cut, only run jobs for modified packages #454

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakemac53
Copy link
Collaborator

No description provided.

@jakemac53 jakemac53 marked this pull request as draft May 26, 2023 20:29
@jakemac53
Copy link
Collaborator Author

Ugh, I ran into an issue here that might be a bit hard to reconcile.

This doesn't appear to work well with our idea of "stages". Jobs in later stages depend on all the jobs from previous stages completing, and I think they get skipped if any of those get skipped. But some of them might be for other packages, which were skipped due to not being modified.

We could do the following potentially:

  • make this new option be incompatible with merge_stages
  • make stages only apply within the same package. So if the first stage for a package completes, all its other stages run, even if some jobs from the earlier stage for different packages failed.
  • maybe only apply the previous logic if this option is enabled.

@jakemac53
Copy link
Collaborator Author

jakemac53 commented May 30, 2023

I think that the easiest solution here is going to be creating separate workflow files for each package, and using the regular workflow level config for filtering which workflows run. We can investigate that option in a different PR as it will look quite different.

Note that it will be incompatible with the logic to merge jobs across packages, but that should be an OK tradeoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant