Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protoc_plugin README install commands @V2 #559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeroasterisk
Copy link

Flutter / Dart V2 no longer installs a pub binary. Now pub commands must be run through the main flutter or dart CLI binary.

Flutter / Dart V2 no longer installs a `pub` binary.  Now `pub` commands must be run through the main `flutter` or `dart` CLI binary.
@google-cla google-cla bot added the cla: yes label Nov 21, 2021
Copy link
Member

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zeroasterisk for the PR and sorry for the late review.

We've updated the README in the meantime with some more instructions so this needs an update now.

Regarding the commands, I think for flutter we run the same commands, but using flutter instead of dart, right? E.g. instead of dart pub global activate ... we use flutter pub global activate .... So we could just say that Flutter users can just replace dart with flutter and that would be shorter. Any opinions on this?

@osa1
Copy link
Member

osa1 commented May 17, 2022

So we could just say that Flutter users can just replace dart with flutter and that would be shorter.

If flutter install in a different path than dart that's another thing to mention.

@zeroasterisk
Copy link
Author

zeroasterisk commented May 18, 2022 via email

@osa1
Copy link
Member

osa1 commented May 19, 2022

OK, thanks.

We should mention that replacing dart with flutter also works, but users should follow https://docs.flutter.dev/get-started/install to update their PATH -- Flutter uses a different executable path than Dart.

I will do this in this PR if I have the permission to edit it, or create a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants