Remove Extension.repeated check argument
#740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The lack of test changes indicates missing coverage. |
We have extension tests in protoc_plugin (extension_test.dart). |
|
But it seems we have no golden-file coverage of the generated code.... maybe that is for the better... |
|
Yeah we don't have golden files for extensions. Tbh I'm not sure why we have golden file tests.. What are they supposed to be checking? |
|
They are a safety guard for changes in the output. I guess with perfect functional test-coverage we could argue they would not be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This argument is always passed the same value in the generated code, so we can remove the function parameter and use the value passed by the generated code as the value of the parameter. This saves one line per extension field in the generated code.