Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude generated files from code coverage #769

Closed
wants to merge 5 commits into from

Conversation

iapicca
Copy link

@iapicca iapicca commented Nov 2, 2022

fix #768

Copy link
Member

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are generated by the plugin so if we want any changes on them the plugin should be generating the changes.

If you could give us some context in the issue (see my question) I can help with the implementation.

@iapicca
Copy link
Author

iapicca commented Nov 3, 2022

These files are generated by the plugin so if we want any changes on them the plugin should be generating the changes.

sorry, I thought they were something like a template since they are in the repo, shouldn't the generated folder be in .gitignore if it's just for testing?

If you could give us some context in the issue (see my question) I can help with the implementation.

@osa1
I added the line // coverage:ignore-file to FileGenerator's _writeHeading's boilerplate
please let me know if there is any other action I should take
(after you vacations, no hurry :) )

@iapicca iapicca closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] exclude generated files from code coverage
2 participants