Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export GeneratedMessageGenericExtensions in generated files #907

Merged
merged 2 commits into from
Jan 6, 2024
Merged

Export GeneratedMessageGenericExtensions in generated files #907

merged 2 commits into from
Jan 6, 2024

Commits on Dec 23, 2023

  1. Export GeneratedMessageGenericExtensions in generated files 

    Currently when a user calls deprecated methods `clone` or `copyWith`,
the deprecation message points to `GeneratedMessageGenericExtensions`
`deepCopy` and `rebuild` methods.

However we can't just replace `clone` with `deepCopy` as currently the
extension is not exported by the generated files. Instead we need to
import the library explicitly in the use site.

We could mention this in the deprecation message ("Use rebuild from
protobuf library instead"), but it's more convenient to just export the
extension in the generated message files.
    @osa1
    osa1 committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    a652ca2 View commit details
    Browse the repository at this point in the history

  2. Fix warning

    @osa1
    osa1 committed Dec 23, 2023
    Configuration menu
    Copy the full SHA
    6950bad View commit details
    Browse the repository at this point in the history