Update to latest lints #920
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Likely want to wait until after #914 |
|
@kevmoo Are the lint fixes done manually or automatically with a tool? We're landing big changes in the g3 version in cl/611552617 and cl/611552616. Those changes touch a lot of files and there will be conflicts with these changes. If these are automatically generated, we should wait until syncing those CLs to open source.
#914 is progressiong slowly and it only changes a few lines, most of the changes are automatically generated by The legacy test removal we can do today without waiting for the CLs (those tests are already removed in the g3 version) if you move them to another PR. |
|
@osa1 – most are automated. Zero rush! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.