weather-dl now uses gsutil cp for file upload.
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A partial implementation of #256. My intention here is to see if this can speed up weather-dl requests.
alxmrs
changed the title
gsutil cp for file upload.gcloud storage alpha cp for file upload.
mahrsee1997
reviewed
Dec 2, 2022
mahrsee1997
approved these changes
Dec 2, 2022
Co-authored-by: Rahul Mahrsee <86819420+mahrsee1997@users.noreply.github.com>
shoyer
reviewed
Dec 2, 2022
Thanks @shoyer. Co-authored-by: Stephan Hoyer <shoyer@google.com>
alxmrs
changed the title
gcloud storage alpha cp for file upload.gcloud alpha storage cp for file upload.
alxmrs
changed the title
gcloud alpha storage cp for file upload.gsutil cp for file upload.
deepgabani8
pushed a commit
that referenced
this pull request
Dec 9, 2022
A partial implementation of #256. Here, we copy data using `gsutil cp` instead of a python routine. This speeds things up, since `gsutil` will parallelize uploads of large files. * weather-dl now uses `gsutil cp` for file upload. A partial implementation of #256. My intention here is to see if this can speed up weather-dl requests. * Temporary: no gsutil version. * Bump weather-dl version. * pinning gsutil version. * Use gcloud alpha storage cp, which is even faster :) * Set up gcloud sdk, accounting for runtime auth issue. * Added error handling to the subprocess call for copying. Co-authored-by: Rahul Mahrsee <86819420+mahrsee1997@users.noreply.github.com> * fix: added import. * Changing subprocess invocation to be more secure. Thanks @shoyer. Co-authored-by: Stephan Hoyer <shoyer@google.com> * nit: dst, not dest. * nit: remove gcloud pip dependency. * Using gsutil for now until we upgrade project deps. Co-authored-by: Rahul Mahrsee <86819420+mahrsee1997@users.noreply.github.com> Co-authored-by: Stephan Hoyer <shoyer@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partial implementation of #256. My intention here is to see if this can speed up weather-dl requests.