Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing test data after clone in Docker image. #351

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

alxmrs
Copy link
Collaborator

@alxmrs alxmrs commented Jun 24, 2023

I believe that our docker images are larger than they should be since they also include checked-in test data. This change adds a short-term fix to delete all test_data folders in each weather_tool before building the rest of the image.

In small experiments, this can save ~190 MiBs of disk space.

This is a band aid for #350.

I believe that our docker images are larger than they should be since they also include checked-in test data. This change adds a short-term fix to delete all `test_data` folders in each weather_tool before building the rest of the image.

In small experiments, this can save ~190 MiBs of disk space.
Copy link
Collaborator

@mahrsee1997 mahrsee1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mahrsee1997 mahrsee1997 merged commit 2c5ea57 into main Sep 18, 2023
@mahrsee1997 mahrsee1997 deleted the docker-rm-testdata branch September 18, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants