Refactored coordinate serialization #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are performing json serialization on coordinates in
get_coordinates()
hereweather-tools/weather_mv/loader_pipeline/util.py
Line 214 in edd742d
Indexing by dimension coordinate labels fails for coordinates that are serialized to types not index-able by xarray (eg
datetime.timedelta
is serialized to floats; so when timedelta is a coordinate,.loc[]
fails as it gives type mis match error)weather-tools/weather_mv/loader_pipeline/bq.py
Lines 213 to 215 in edd742d
This is fixed by performing json serialization after the indexing is done.