weather-mv will ingest data into BQ from Zarr much faster.
#357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found a couple of errors with loading a Zarr dataset into BigQuery.
mahrsee1997
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Overall LGTM.
@dabhicusp / @DarshanSP19, could you please provide the benchmarking results for the current main branch as compared to this specific branch?
mahrsee1997
reviewed
Jul 17, 2023
| paths | ||
| | 'OpenChunks' >> xbeam.DatasetToChunks(ds, chunks) | ||
| | 'ExtractRows' >> beam.FlatMapTuple(self.chunks_to_rows) | ||
| | 'Window' >> beam.WindowInto(window.FixedWindows(60)) |
dabhicusp
reviewed
Jul 18, 2023
|
Data after running pipelines for mentioned cases.
This changes are relatively fast than before for zarr batch ingestion. |
fredzyda
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weather-mv bq's previous Zarr ingestion system only used one worker. This PR uses Xarray-Beam for Zarr ingestion, in order to distributedxr.Datasetchunks across beam workers. This improves ingestion into BQ.Outstanding issues: I can't find a way to incrementally load rows into BQ from Zarr. While I've used windowing on fixed intervals to break up a large ingestion job into smaller parts, it seems like the actual writing to BQ gets stuck in a reshuffle step within the
WriteToBigQuerytransform. In this PR or a future PR, let's try to find a way to incrementally write rows to BQ once they've been processed, instead of having to wait for the entire dataset to be processed. CC: @dabhicusp.