-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add gRPC as a direct dependency for GAPICs #2082
Draft
ohmayr
wants to merge
9
commits into
main
Choose a base branch
from
add-grpc-as-a-direct-dependency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ohmayr
force-pushed
the
add-grpc-as-a-direct-dependency
branch
from
July 29, 2024 21:25
8fbca6c
to
5350937
Compare
ohmayr
force-pushed
the
add-grpc-as-a-direct-dependency
branch
from
July 29, 2024 21:50
5350937
to
9d4215c
Compare
product-auto-label
bot
added
size: s
Pull request size is small.
and removed
size: xs
Pull request size is extra small.
labels
Jul 30, 2024
If possible we should also try to fix #2020 which is related |
Assigning back to @ohmayr to address #2082 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2019 🦕