Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(toys): Stop background processes using gen on_interrupt directive #1036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(toys): Stop background processes using gen on_interrupt directive #1036

wants to merge 1 commit into from

Conversation

aandreassa
Copy link
Contributor

@aandreassa aandreassa commented Jan 23, 2024 •
edited
Loading

Convenience tool to stop all processes spawned via toys gen (which may live in the background)

Repro steps:

  1. Change gapic-generator/templates/default/service/rest/test/method/_normal.erb to reference an incorrect value (e.g. s/field.name/field.wrong_name)
  2. toys gen language_v1.
  3. Once process hangs, send interrupt signal.

@aandreassa aandreassa self-assigned this Jan 23, 2024
@aandreassa aandreassa changed the title feat(gapic-ruby-generator): add tool to stop background process from … feat(gapic-generator-ruby): add tool to stop background process from … Jan 23, 2024
@aandreassa aandreassa marked this pull request as ready for review January 23, 2024 01:02
@aandreassa aandreassa requested a review from a team as a code owner January 23, 2024 01:02
@aandreassa aandreassa changed the title feat(gapic-generator-ruby): add tool to stop background process from … feat(gapic-ruby-generator): add logic to stop background process from toys gen on SIGINT Jan 23, 2024
aandreassa
aandreassa commented Jan 23, 2024
View reviewed changes
.toys/.toys.rb Outdated Show resolved Hide resolved
dazuma
dazuma requested changes Jan 24, 2024
View reviewed changes
Copy link
Member

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this technique should be really helpful. Just have some requests:

.toys/.toys.rb Outdated Show resolved Hide resolved
.toys/.toys.rb Outdated Show resolved Hide resolved
.toys/.toys.rb Outdated Show resolved Hide resolved
@aandreassa aandreassa changed the title feat(gapic-ruby-generator): add logic to stop background process from toys gen on SIGINT chore(toys): Stop background processes using gen on_interrupt directive Aug 7, 2024
@aandreassa aandreassa requested a review from dazuma August 7, 2024 01:02
@aandreassa aandreassa closed this Oct 31, 2024
@aandreassa aandreassa reopened this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dazuma dazuma Awaiting requested review from dazuma

Requested changes must be addressed to merge this pull request.

Assignees

@aandreassa aandreassa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aandreassa @dazuma