Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable ending editing on resize #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stevelandeyasana
Copy link
Contributor

@stevelandeyasana stevelandeyasana commented May 24, 2024

I'm working on a comment editor which presents as a persistent bottom sheet. I was finding that when I drag between detents, my text field was being forced to resign its responder, which is bad. There was also a visual bug where the sheet would be the wrong height during the drag due to its offsets being computed with the keyboard up.

Rather than removing the behavior for all users, I added a config option, but I'm not convinced it's better than simply removing the call to endEditing(). It would be better to have some kind of configurable callback so users can choose to end editing if it makes sense for their use case. What do you think?

This line was added a very long time ago, maybe you have some context you can share @gordontucker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant