chore(storage): Simplify store interfaces and abstractions (pt 3) #10516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
force-pushed
the
chaudum/store-interfaces-v5
branch
from
7e012ca to
76934e7
Compare
chaudum
force-pushed
the
chaudum/store-interfaces-v3
branch
from
f37324f to
9ca7323
Compare
chaudum
force-pushed
the
chaudum/store-interfaces-v5
branch
4 times, most recently
from
b2eb5f0 to
d7cad48
Compare
chaudum
force-pushed
the
chaudum/store-interfaces-v5
branch
from
340a623 to
6698aff
Compare
chaudum
force-pushed
the
chaudum/store-interfaces-v5
branch
from
6698aff to
d978e47
Compare
ashwanthgoli
reviewed
Nov 3, 2023
Use composition instead of "inline inheritance". This requires LokiStore to implement additional methods that were previously inherited from the inline Store field. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Use composition instead of "inline inheritance". This requires storeEntry to implement additional methods to that were previously inherited from ChunkWriter. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Use composition instead of "inline inheritance". This requires to implement additional methods that were previously inherited from the inline Store field. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
AsyncStore and CompositeStore share the same interface implementation. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
instead of full SchemaConfig Both stores only ever operate on a single schema period and the schema was only used to determine the external key of a chunk. This can be done by the PeriodConfig as well. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
force-pushed
the
chaudum/store-interfaces-v5
branch
from
d978e47 to
8a53e34
Compare
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In an attempt to simplify the storage layer, this PR implements best practices:
Special notes for your reviewer:
See individual commit messages.
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR