Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated ruler configs in limits.go #11105

Closed
wants to merge 14 commits into from

Conversation

shantanualsi
Copy link
Contributor

@shantanualsi shantanualsi commented Nov 1, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 1, 2023
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Nov 2, 2023
@shantanualsi shantanualsi force-pushed the shantanu/remove-ruler-configs branch 2 times, most recently from 7292d47 to 6978a06 Compare November 8, 2023 07:31
@shantanualsi shantanualsi force-pushed the shantanu/remove-ruler-configs branch from 6978a06 to f68cffa Compare November 16, 2023 10:10
Copy link
Contributor

Trivy scan found the following vulnerabilities:

@shantanualsi shantanualsi marked this pull request as ready for review November 16, 2023 10:14
@shantanualsi shantanualsi requested a review from a team as a code owner November 16, 2023 10:14
Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Docs LGTM

@shantanualsi shantanualsi marked this pull request as draft April 10, 2024 06:55
@shantanualsi
Copy link
Contributor Author

We'll wait for an appropriate release in order to remove these configs. Needs more extensive testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants