-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document caveats for 2.x to 3.x loki helm chart upgrades #11199
Document caveats for 2.x to 3.x loki helm chart upgrades #11199
Conversation
Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
ptal @JStickler |
Trivy scan found the following vulnerabilities:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Docs team] Sorry to be late to respond, I was on vacation last week. A couple of suggestions for how to rephrase things, but thanks so much for updating this!
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
thank you @JStickler, these were perfect additions! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**What this PR does / why we need it**: grafana#9427 discusses a few notable gotchas and differences between `v2.x` and `v3.x` helm charts. In this PR, I would like to propose aggregation of the information from the mentioned issue and appending that to the upgrade guide. **Which issue(s) this PR fixes**: see also: grafana#9427 **Special notes for your reviewer**: **Checklist** - [x] Reviewed the [`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md) guide (**required**) - [x] Documentation added - [x] Changes that require user attention or interaction to upgrade are documented in `docs/sources/setup/upgrade/_index.md` --------- Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com> Co-authored-by: J Stickler <julie.stickler@grafana.com> Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
What this PR does / why we need it:
#9427 discusses a few notable gotchas and differences between
v2.x
andv3.x
helm charts. In this PR, I would like to propose aggregation of the information from the mentioned issue and appending that to the upgrade guide.Which issue(s) this PR fixes:
see also: #9427
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md