Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document caveats for 2.x to 3.x loki helm chart upgrades #11199

Merged
merged 9 commits into from
Nov 23, 2023

Conversation

wozniakjan
Copy link
Contributor

What this PR does / why we need it:
#9427 discusses a few notable gotchas and differences between v2.x and v3.x helm charts. In this PR, I would like to propose aggregation of the information from the mentioned issue and appending that to the upgrade guide.

Which issue(s) this PR fixes:
see also: #9427

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
@wozniakjan wozniakjan requested a review from a team as a code owner November 10, 2023 12:16
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 10, 2023
@wozniakjan
Copy link
Contributor Author

ptal @JStickler

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Trivy scan found the following vulnerabilities:

Copy link
Contributor

@JStickler JStickler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Docs team] Sorry to be late to respond, I was on vacation last week. A couple of suggestions for how to rephrase things, but thanks so much for updating this!

JStickler and others added 4 commits November 22, 2023 16:07
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
@wozniakjan
Copy link
Contributor Author

thank you @JStickler, these were perfect additions! :)

Copy link
Contributor

@MichelHollands MichelHollands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MichelHollands MichelHollands merged commit a971dcb into grafana:main Nov 23, 2023
8 checks passed
JStickler added a commit that referenced this pull request Nov 27, 2023
JStickler added a commit that referenced this pull request Nov 27, 2023
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
**What this PR does / why we need it**:
grafana#9427 discusses a few notable
gotchas and differences between `v2.x` and `v3.x` helm charts. In this
PR, I would like to propose aggregation of the information from the
mentioned issue and appending that to the upgrade guide.

**Which issue(s) this PR fixes**:
see also: grafana#9427

**Special notes for your reviewer**:

**Checklist**
- [x] Reviewed the
[`CONTRIBUTING.md`](https://github.com/grafana/loki/blob/main/CONTRIBUTING.md)
guide (**required**)
- [x] Documentation added
- [x] Changes that require user attention or interaction to upgrade are
documented in `docs/sources/setup/upgrade/_index.md`

---------

Signed-off-by: Jan Wozniak <wozniak.jan@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.9.x size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants