Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable/disable bloom gateway per tenant #11203

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Enable/disable bloom gateway per tenant #11203

merged 1 commit into from
Nov 13, 2023

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Nov 10, 2023

This commits adds a per-tenant setting to enable/disable the use of the bloom gateway component for filtering chunks.

As an operator, you want to control what tenant can use the filtering of chunks based on search string, because the creation of the bloom filters requires a significant amount of resources.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Nov 10, 2023
@chaudum chaudum marked this pull request as ready for review November 10, 2023 15:27
@chaudum chaudum requested a review from a team as a code owner November 10, 2023 15:27
@chaudum
Enable/disable bloom gateway per tenant
4ebe952 
This commits adds a per-tenant setting to enable/disable the use of the
bloom gateway component for filtering chunks.

As an operator, you want to control what tenant can use the filtering of
chunks based on search string, because the creation of the bloom filters
requires a significant amount of resources.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/per-tenant-setting-bloom-gateway-enable-filtering branch from b567ed9 to 4ebe952 Compare November 10, 2023 15:32
@chaudum chaudum merged commit e5b006c into main Nov 13, 2023
6 checks passed
@chaudum chaudum deleted the chaudum/per-tenant-setting-bloom-gateway-enable-filtering branch November 13, 2023 06:38
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@chaudum @rhnasc
Enable/disable bloom gateway per tenant (grafana#11203)
c8f7dcb 
This commits adds a per-tenant setting to enable/disable the use of the
bloom gateway component for filtering chunks.

As an operator, you want to control what tenant can use the filtering of
chunks based on search string, because the creation of the bloom filters
requires a significant amount of resources.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poyzannur poyzannur poyzannur approved these changes

Assignees
No one assigned
Labels
size/S type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaudum @poyzannur