Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logcli: Check for errors before checking for exists when fetching data (backport release-3.2.x) #14844

Open
wants to merge 3 commits into
base: release-3.2.x
Choose a base branch
from

Conversation

loki-gh-app[bot]
Copy link
Contributor

@loki-gh-app loki-gh-app bot commented Nov 8, 2024

Backport 9e7d2f2 from #14780


What this PR does / why we need it:
When getting data from object storage, we're first checking for the exists return and only then for the error returned. Everytime an error is returned an exists=false is also returned, and that is taken more precedence than the error itself.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@loki-gh-app loki-gh-app bot requested a review from a team as a code owner November 8, 2024 12:17
@loki-gh-app loki-gh-app bot added backport size/XS type/bug Somehing is not working as expected labels Nov 8, 2024
@loki-gh-app loki-gh-app bot requested a review from DylanGuedes November 8, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants