-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Improve docs for min and max table offsets #14890
fix: Improve docs for min and max table offsets #14890
Conversation
# CLI flag: -bloom-build.planner.max-table-offset | ||
[max_table_offset: <int> | default = 2] | ||
[max_table_offset: <int> | default = 1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we increase the default to 7? I think this would make sense in the broader context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitant to do that until we get more confident about how good the build process scales. If data doesn't change as often, building today + tomorrow should work more most of the cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with that
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14890-to-k227 origin/k227
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x fd9d33241d4a5cdf0066233bf8bdda69ea23a9f7 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14890-to-k227
# Create the PR body template
PR_BODY=$(gh pr view 14890 --json body --template 'Backport fd9d33241d4a5cdf0066233bf8bdda69ea23a9f7 from #14890{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix: Improve docs for min and max table offsets (backport k227)' --body-file - --label 'size/M' --label 'type/docs' --label 'backport' --base k227 --milestone k227 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14890-to-k227
# Create a pull request where the `base` branch is `k227` and the `compare`/`head` branch is `backport-14890-to-k227`.
# Remove the local backport branch
git switch main
git branch -D backport-14890-to-k227 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-14890-to-k227 origin/k227
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x fd9d33241d4a5cdf0066233bf8bdda69ea23a9f7 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-14890-to-k227
# Create the PR body template
PR_BODY=$(gh pr view 14890 --json body --template 'Backport fd9d33241d4a5cdf0066233bf8bdda69ea23a9f7 from #14890{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title 'fix: Improve docs for min and max table offsets (backport k227)' --body-file - --label 'size/M' --label 'type/docs' --label 'backport' --base k227 --milestone k227 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-14890-to-k227
# Create a pull request where the `base` branch is `k227` and the `compare`/`head` branch is `backport-14890-to-k227`.
# Remove the local backport branch
git switch main
git branch -D backport-14890-to-k227 |
Co-authored-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit fd9d332)
Co-authored-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit fd9d332)
What this PR does / why we need it:
The docs for min and max offsets are a bit difficult to reason about. This PR improves them with examples and sets the default min offset to 0 (build from today), and the max to 1 (build till tomorrow).
We also add a test for the tables iterator.
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR