-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thanos): add support for aliyun oss and baidu bos #14891
Conversation
@liguozhong, @arcosx loki is planning to introduce object store clients based off https://github.com/thanos-io/objstore, but we do not have a test environment to run a sanity check for aliyun oss and baidu bos. I noticed that you folks added the support for these providers. It would be great if you could help run a sanity check with this change on your test environment :) Happy to help with any questions you have |
OK,I will test for bos. |
@arcosx thanks a lot! Just to clarity, thanos clients have to be explicitly enabled by setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a code POV lgtm
@@ -138,7 +150,7 @@ func (cfg *Config) disableRetries(backend string) error { | |||
cfg.Azure.MaxRetries = 1 | |||
case Swift: | |||
cfg.Swift.MaxRetries = 1 | |||
case Filesystem: | |||
case Filesystem, Alibaba, BOS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed: with thanos-io/objstore#147 merged we can now define these for these two no? Also fine to do it on a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both bos and oss do not have a any way to configure retries, that's what i gathered from my last search :)
What this PR does / why we need it:
Adds support for
aliyun oss
andbaidu bos
thanos clients.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
deprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR