feat: log stream limit errors back to insights logging #15163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callum Styan <callumstyan@gmail.com>
trevorwhitney
approved these changes
Nov 27, 2024
chaudum
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
stream_limit, as in the limit for the maximum # of active streams a tenant may have, is only propagated back to end users via HTTP errors to their logs agent. We have internal logging of these errors as well, but it would be useful to also propagate such error messages back to Grafana Cloud Logs users in their Logs Usage Insights datasource so that they can more easily self serve investigations into these errors, and so we could also build a dashboard to aid in such investigations if we decided to do so.This PR adds logging of the
stream_limiterrors to thewriteFailureslogging, which is just a simple wrapper for correctly logging the tenant ID andinsight=trueto ingestion path logging which we want to propagated to usage insights datasources.