Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Mixin): Fix per_namespace_label not used #15258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Syndlex
Copy link

@Syndlex Syndlex commented Dec 4, 2024

Mixin not using per_namespace_label in generation of Dashboards.

Mixin is not changing when per_namespace_label is set.

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@Syndlex Syndlex requested a review from a team as a code owner December 4, 2024 15:43
@CLAassistant
Copy link

CLAassistant commented Dec 4, 2024

CLA assistant check
All committers have signed the CLA.

@Syndlex Syndlex changed the title chore(Mixin): [Mixin] - Fix per_namespace_label not used Dec 4, 2024
@Syndlex Syndlex changed the title [Mixin] - Fix per_namespace_label not used chore(Mixin) - Fix per_namespace_label not used Dec 4, 2024
@Syndlex Syndlex changed the title chore(Mixin) - Fix per_namespace_label not used chore(Mixin): Fix per_namespace_label not used Dec 4, 2024
…shboards.

Mixin is not changing when per_namespace_label is set.
@Syndlex Syndlex force-pushed the chore/mixin-namespace branch from b4753eb to 374f830 Compare December 4, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants