Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Increase buffer size to prevent timeouts in tests #15498

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

paul1r
Copy link
Collaborator

@paul1r paul1r commented Dec 19, 2024

What this PR does / why we need it:
A recent PR caused multiple occurrences of timeouts in this particular test. This PR increases the buffer size to work around this.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@paul1r paul1r requested a review from a team as a code owner December 19, 2024 17:51
@paul1r
Copy link
Collaborator Author

paul1r commented Dec 19, 2024

go test -race -count=500 -run Test_Push/batches_push_requests 
PASS
ok  	github.com/grafana/loki/v3/pkg/pattern/aggregation	2.173s

Copy link
Collaborator

@trevorwhitney trevorwhitney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Paul!

@paul1r paul1r merged commit 606f2f1 into main Dec 19, 2024
60 checks passed
@paul1r paul1r deleted the paul1r/test_push_timeout branch December 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants