Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: blockbuilder timespan #15522

Draft
wants to merge 1 commit into
base: blockbuilder-kafka-clients
Choose a base branch
from

Conversation

ashwanthgoli
Copy link
Contributor

What this PR does / why we need it:

  • creates one job per partition to consume records spanning a duration of targetPeriod
  • stores the last committed record timestamp as metadata in the commit record, we use this to plan the next job for a partition

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@ashwanthgoli ashwanthgoli changed the title Blockbuilder timespan wip: blockbuilder timespan Dec 20, 2024
@ashwanthgoli ashwanthgoli changed the base branch from main to blockbuilder-kafka-clients December 20, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant