-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typescript migration #223
base: master
Are you sure you want to change the base?
typescript migration #223
Conversation
4659cab
to
64e606a
Compare
63a40e5
to
881f6d3
Compare
881f6d3
to
9f912f6
Compare
c94d7df
to
7db5316
Compare
|
||
/** | ||
* The GraphQL type equivalent of the People resource | ||
*/ | ||
const PersonType = new GraphQLObjectType({ | ||
const PersonType: GraphQLObjectType<Person> = new GraphQLObjectType<Person>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Urigo this doesn't make sense, I can't believe the type fidelity has fallen this much in graphql
, migrating from flow to typescript it's even more apparent, I remember types in 14 at least had more inference, am I doing something incorrectly here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redo of #191 , with a
graphql
upgrade as welltype: module
so that we're using the latest and greatest in module resolution/etcvitest.config.ts
contains an alias to use cjs graphql becausegraphql-relay
doesn't publish a module bundle yet (otherwise tests have realm error)cache/data.json
both in netlify and github actions for faster CIpackage-lock.json