use Path.Combine for portable path

gravity-api · Oct 18, 2020 · 4e2f4cb · 4e2f4cb
1 parent bbd33df
commit 4e2f4cb
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 3 deletions.
diff --git a/...rp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Extensions/LoggerExtensions.cs b/...rp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Extensions/LoggerExtensions.cs
@@ -8,6 +8,9 @@
 
 namespace Gravity.Abstraction.Logging.Extensions
 {
+    /// <summary>
+    /// Extensions package for ILogger.
+    /// </summary>
     public static class LoggerExtensions
     {
         /// <summary>

diff --git a/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/ILogger.cs b/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/ILogger.cs
@@ -5,6 +5,9 @@
 
 namespace Gravity.Abstraction.Logging
 {
+	/// <summary>
+	/// ILogger interface.
+	/// </summary>
 	public interface ILogger
 	{
 		/// <summary>

diff --git a/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/LogFactory.cs b/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/LogFactory.cs
@@ -5,6 +5,9 @@
 
 namespace Gravity.Abstraction.Logging
 {
+    /// <summary>
+    /// Factory for creating loggers based on ILogger.
+    /// </summary>
     public static class LogFactory
     {
         /// <summary>

diff --git a/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Logger.cs b/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/Logger.cs
@@ -9,6 +9,9 @@
 
 namespace Gravity.Abstraction.Logging
 {
+    /// <summary>
+    /// Base class for all ILogger implementations.
+    /// </summary>
     public abstract class Logger : ILogger
     {
         // members: state

diff --git a/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/TraceLogger.cs b/src/csharp/Gravity.Abstraction.Logging/Gravity.Abstraction.Logging/TraceLogger.cs
@@ -93,12 +93,12 @@ public override void OnExecutor(string level, IDictionary<string, object> logMes
         private void SetupTraceListener(string instanceName, string inDirectory)
         {
             // setup directory
-            var directory = string.IsNullOrEmpty(inDirectory)
+            var directory = string.IsNullOrEmpty(inDirectory) || inDirectory.Equals(".")
                 ? Environment.CurrentDirectory
                 : inDirectory;
 
             // initialize listener
-            Directory.CreateDirectory(directory.Replace("\\\\", "\\").Replace("//", "/"));
+            Directory.CreateDirectory(directory);
 
             // setup conditions
             var exists = System.Diagnostics.Trace
@@ -111,7 +111,7 @@ private void SetupTraceListener(string instanceName, string inDirectory)
             }
 
             // setup trace
-            var fileName = $"{directory}\\{instanceName}-{DateTime.Now:yyyyMMdd}.log";
+            var fileName = Path.Combine(directory, $"{instanceName}-{DateTime.Now:yyyyMMdd}.log");
             System.Diagnostics.Trace.AutoFlush = true;
             System.Diagnostics.Trace.Listeners.Add(new TextWriterTraceListener(fileName, name: instanceName));
         }