-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5033 roads bridges tunnels queries #5035
5033 roads bridges tunnels queries #5035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good - apart from the column name thing noted.
This by the way has an effect on actual rendering - it removes an inconsistency in dealing with leisure=slipway
:
Of course there are very few or no leisure=slipway
bridges or tunnels in reality.
Thanks for taking the time to do maintenance work like this - we do this way too little. And of course it is rather unattractive compared to actual design work
project.mml
Outdated
'null', | ||
NULL, | ||
NULL AS int_surface, | ||
NULL AS access, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Column name is int_access
.
@StyXman - this only requires a small change with the column name, otherwise it seems ready to be merged. |
Since other changes are going to be affected by this i don't want to have this pending for too long so i fixed the naming issue and am going to merge this. |
Fixes #5033. This is WIP/Draft.
Changes proposed in this pull request:
Test rendering with links to the example places:
Before
After