Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5033 roads bridges tunnels queries #5035

Merged

Conversation

StyXman
Copy link
Contributor

@StyXman StyXman commented Nov 1, 2024

Fixes #5033. This is WIP/Draft.

Changes proposed in this pull request:

Test rendering with links to the example places:

Before

After

@StyXman StyXman marked this pull request as draft November 1, 2024 07:15
@StyXman StyXman marked this pull request as ready for review November 2, 2024 10:30
Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good - apart from the column name thing noted.

This by the way has an effect on actual rendering - it removes an inconsistency in dealing with leisure=slipway:

before:
service+slipway before

after:
service+slipway after

Of course there are very few or no leisure=slipway bridges or tunnels in reality.

Thanks for taking the time to do maintenance work like this - we do this way too little. And of course it is rather unattractive compared to actual design work

project.mml Outdated
'null',
NULL,
NULL AS int_surface,
NULL AS access,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Column name is int_access.

@imagico
Copy link
Collaborator

imagico commented Nov 11, 2024

@StyXman - this only requires a small change with the column name, otherwise it seems ready to be merged.

@imagico
Copy link
Collaborator

imagico commented Nov 27, 2024

Since other changes are going to be affected by this i don't want to have this pending for too long so i fixed the naming issue and am going to merge this.

@imagico imagico merged commit 5791e79 into gravitystorm:master Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

roads vs tunnels vs bridges SQL queries
2 participants