Check timestamp columns (created_at, updated_at) are NOT NULL #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
force-pushed
the
timestamps-not-null
branch
2 times, most recently
from
b44c5c6
to
b6a657f
Compare
fatkodima
reviewed
Sep 2, 2024
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
jdufresne
force-pushed
the
timestamps-not-null
branch
from
b6a657f
to
e62b314
Compare
fatkodima
reviewed
Sep 2, 2024
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
jdufresne
force-pushed
the
timestamps-not-null
branch
from
e62b314
to
18efe4a
Compare
gregnavis
requested changes
Sep 3, 2024
There was a problem hiding this comment.
Thank you for your contribution, @jdufresne. I appreciate the effort you put into creating a PR.
I left one small comment that will hopefully improve DX.
lib/active_record_doctor/detectors/missing_non_null_constraint.rb
Outdated
Show resolved
Hide resolved
gregnavis
added
new feature
Once the timestamps columns are established on a table, they might as well be NOT NULL to enforce their existence. All ActiveRecord operations set these values so they will always exist under normal usage. Fixes gregnavis#184
jdufresne
force-pushed
the
timestamps-not-null
branch
from
18efe4a
to
d0fc304
Compare
gregnavis
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Thank you for the contribution, @jdufresne.
@fatkodima, could you resolve the outstanding conversations if your concerns were addressed?
|
Lgtm 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the timestamps columns are established on a table, they might as well be NOT NULL to enforce their existence. All ActiveRecord operations set these values so they will always exist under normal usage.
Fixes #184