CI: Check for changed files (sqldelight#5133)

* CI: Check for changed files * Fix sqldelight-compiler:integration-tests
griffio · Apr 7, 2024 · 0a62baa · 0a62baa
1 parent 4f426e3
commit 0a62baa
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/.github/workflows/PR.yml b/.github/workflows/PR.yml
@@ -97,6 +97,9 @@ jobs:
         if: matrix.os == 'macOS-14' && matrix.job == 'test'
         run: ./gradlew iosX64Test --stacktrace --parallel
 
+      - name: Check for changed files
+        run: test -z "$(git status --porcelain)"
+
   verify_intellij:
     runs-on: ubuntu-latest
 

diff --git a/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/GroupQueries.kt b/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/GroupQueries.kt
@@ -17,7 +17,7 @@ public class GroupQueries(
 
   public fun <T : Any> selectFromTable2(mapper: (something: String?, nice: String?) -> T): Query<T>
       = Query(-620_576_550, arrayOf("myftstable2"), driver, "Group.sq", "selectFromTable2", """
-  |SELECT *
+  |SELECT myftstable2.something, myftstable2.nice
   |FROM myftstable2
   """.trimMargin()) { cursor ->
     mapper(

diff --git a/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/PlayerQueries.kt b/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/PlayerQueries.kt
@@ -60,7 +60,7 @@ public class PlayerQueries(
     shoots: Shoots,
   ) -> T): Query<T> = Query(-1_634_440_035, arrayOf("player"), driver, "Player.sq", "allPlayers",
       """
-  |SELECT *
+  |SELECT player.name, player.number, player.team, player.shoots
   |FROM player
   """.trimMargin()) { cursor ->
     mapper(
@@ -248,7 +248,7 @@ public class PlayerQueries(
             bindString(3, playerAdapter.shootsAdapter.encode(shoots))
           }
       driver.executeQuery(-452_007_404, """
-          |SELECT *
+          |SELECT player.name, player.number, player.team, player.shoots
           |  FROM player
           |  WHERE player.rowid = last_insert_rowid()
           """.trimMargin(), mapper, 0)
@@ -271,7 +271,7 @@ public class PlayerQueries(
 
     override fun <R> execute(mapper: (SqlCursor) -> QueryResult<R>): QueryResult<R> =
         driver.executeQuery(null, """
-    |SELECT *
+    |SELECT player.name, player.number, player.team, player.shoots
     |FROM player
     |WHERE team ${ if (team == null) "IS" else "=" } ?
     """.trimMargin(), mapper, 1) {
@@ -296,7 +296,7 @@ public class PlayerQueries(
     override fun <R> execute(mapper: (SqlCursor) -> QueryResult<R>): QueryResult<R> {
       val numberIndexes = createArguments(count = number.size)
       return driver.executeQuery(null, """
-          |SELECT *
+          |SELECT player.name, player.number, player.team, player.shoots
           |FROM player
           |WHERE number IN $numberIndexes
           """.trimMargin(), mapper, number.size) {
@@ -324,7 +324,7 @@ public class PlayerQueries(
 
     override fun <R> execute(mapper: (SqlCursor) -> QueryResult<R>): QueryResult<R> =
         driver.executeQuery(-1_258_650_806, """
-    |SELECT *
+    |SELECT player.name, player.number, player.team, player.shoots
     |FROM player
     |WHERE (number, name) > (?, ?)
     """.trimMargin(), mapper, 2) {

diff --git a/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/TeamQueries.kt b/sqldelight-compiler/integration-tests/src/test/kotlin/com/example/TeamQueries.kt
@@ -109,7 +109,7 @@ public class TeamQueries(
 
     override fun <R> execute(mapper: (SqlCursor) -> QueryResult<R>): QueryResult<R> =
         driver.executeQuery(null, """
-    |SELECT *
+    |SELECT team.name, team.captain, team.inner_type, team.coach
     |FROM team
     |WHERE inner_type ${ if (inner_type == null) "IS" else "=" } ?
     """.trimMargin(), mapper, 1) {