release: trigger release processes when release workflow succeeded #47
+143
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otegami
force-pushed
the
release-run-async-task
branch
2 times, most recently
from
3700adc to
a82b318
Compare
GitHub: groongaGH-43 In this PR, we set up how release flow is triggered from webhook requests.
otegami
force-pushed
the
release-run-async-task
branch
from
a82b318 to
e4f8727
Compare
otegami
changed the title
|
I'm thinking I will add the test at the following PRs because this PR has already had a lots of changes. |
abetomo
reviewed
Dec 19, 2024
| private | ||
|
|
||
| def workflow_tag? | ||
| return if branch |
There was a problem hiding this comment.
Suggested change
| return if branch | |
| return false unless branch |
条件合ってます？
? なので真偽値を返すと良さげ。
abetomo
reviewed
Dec 19, 2024
| require_relative "response" | ||
| require_relative "source-archive" |
There was a problem hiding this comment.
mainの変更を取り込めてなかったので、後ほどrebaseします 🙏🏾
abetomo
reviewed
Dec 19, 2024
|
|
||
| def parse_payload(request, response) | ||
| unless request.media_type == "application/json" | ||
| response.set(:bad_request, "invalid payload format") |
There was a problem hiding this comment.
parse_payload で response.set までしちゃうのは越権行為な気がするんですがどうでしょうか。
parse ならばそれだけに専念したほうが良さそうに思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: GH-43
In this PR, we set up how release flow is triggered from webhook
requests.