Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Simplifying root configuration lookup #3684

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yhakbar
Copy link
Collaborator

@yhakbar yhakbar commented Dec 19, 2024

Description

There's currently logic that includes ignoring certain configurations when found, etc.

Instead of doing that, let's just look for configuration in parents that have valid catalog configurations, and use those.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Updated catalog.

@yhakbar yhakbar force-pushed the fix/simplifying-root-configuration-lookup branch from 747e92e to d4191ae Compare December 19, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant