Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sustainable Kibana Architecture: auto PR #2

Closed
wants to merge 1 commit into from
Closed

Conversation

gsoldevila
Copy link
Owner

PHASE 1 - ESLint constraints

  • Manifests (plugin export function + setup + start contracts)
  • Import statements
  • group: 'platform' | 'observability' | 'security' | 'search'
  • visibility: 'private' | 'shared' # platform only, solutions are 'private'

PHASE 2 - Categorising modules (packages and plugins)

  • Not moving, only tagging
  • Reveal inter-group dependencies

PHASE 3 - Actually moving stuff

  <!-- 'src/platform/(packages|plugins)/(private|shared)', -->
  'x-pack/platform/(packages|plugins)/(private|shared)',

  'x-pack/solutions/observability/plugins',
  'x-pack/solutions/observability/packages',
  'x-pack/solutions/security/plugins',
  'x-pack/solutions/security/packages',
  'x-pack/solutions/search/plugins',
  'x-pack/solutions/search/packages',
  • Command-line tool to relocate modules, by owner
  • 38 teams => 38 big PRs

node scripts/manifest --relocate @elastic/appex-ai-infra

Manually search for [/\]

const TEAMS = [
'@elastic/kibana-core', https://github.com/elastic/pull/201653
'@elastic/appex-ai-infra', https://github.com/elastic/pull/202410
'@elastic/appex-sharedux', ai-infra
'@elastic/docs', https://github.com/elastic/pull/202416
'@elastic/fleet', shallow-2 https://github.com/elastic/pull/202422
* x-pack/platform/plugins/shared/fleet/cypress/tasks/login.ts
* x-pack/platform/plugins/shared/fleet/cypress/reporter_config.json
'@elastic/kibana-cloud-security-posture',
'@elastic/kibana-data-discovery',
'@elastic/kibana-esql',
'@elastic/kibana-localization',
'@elastic/kibana-management',
'@elastic/kibana-operations',
'@elastic/kibana-presentation',
'@elastic/kibana-reporting-services',
'@elastic/kibana-security',
'@elastic/kibana-visualizations',
'@elastic/logstash',
'@elastic/ml-ui',
'@elastic/obs-ai-assistant',
'@elastic/obs-entities',
'@elastic/obs-knowledge-team',
'@elastic/obs-ux-infra_services-team',
'@elastic/obs-ux-logs-team',
'@elastic/obs-ux-management-team',
'@elastic/obs-ux-onboarding-team',
'@elastic/observability-ui',
'@elastic/response-ops',
'@elastic/search-kibana',
'@elastic/security-asset-management',
'@elastic/security-defend-workflows',
'@elastic/security-detection-engine',
'@elastic/security-detection-rule-management',
'@elastic/security-detections-response',
'@elastic/security-generative-ai',
'@elastic/security-scalability',
'@elastic/security-solution',
'@elastic/security-threat-hunting-explore',
'@elastic/security-threat-hunting-investigations',
'@elastic/security-threat-hunting',
'@elastic/stack-monitoring',
'@simianhacker @flash1293 @dgieselaar',
'@vigneshshanmugam',
];

@gsoldevila gsoldevila closed this Dec 3, 2024
@gsoldevila gsoldevila deleted the test-branch branch December 3, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant