Fix a segfault in mechglue #103
Conversation
Avoid a segfault in case the src OID_set came from a gssx_OID_set with gssx_OID_set_len==0 (see gp_conv_gssx_to_oid_set()) Signed-off-by: Volker Lendecke <vl@samba.org>
|
Hi Volker, I wonder if we should rather return an error if the oldset is empty. |
|
I'm playing with the gssproxy protocol, and got mechglue to crash. This is not with the upstream gssproxy daemon that this project provides, but I thought it might be worthwhile to not crash unsuspecting clients no matter what happens on the daemon side. See also the SIGPIPE patch of a while ago. With the real gssproxy this should never happen. |
|
I see, would you mind changing the patch to return an error instead of success + empty set ? |
|
Sure, but I guess this should happen when parsing the bytes coming from the server. Let's close this PR, I'll take a fresh look. |
Protect mechglue against 0-length OID_set coming from the gssproxy