Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pages workflow syntax #177

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

funnelfiasco
Copy link
Collaborator

As part of a fix for issue #175, I moved the permissions in the step. This is incorrect. So this commit moves it to the job, which appears to be the correct place.

As part of a fix for issue guacsec#175, I moved the permissions in the step.
This is incorrect. So this commit moves it to the job, which appears to
be the correct place.

Signed-off-by: Ben Cotton <ben@kusari.dev>
@funnelfiasco funnelfiasco added the bug Something isn't working label Nov 5, 2024
Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for resonant-wisp-1a517a ready!

Name Link
🔨 Latest commit 4a60085
🔍 Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/672a3e7d61cfec0008c1a0fe
😎 Deploy Preview https://deploy-preview-177--resonant-wisp-1a517a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@funnelfiasco
Copy link
Collaborator Author

I installed VSCode's GitHub Actions plugin and it no longer complains about this file, so I think it's a real fix. :-)

@funnelfiasco
Copy link
Collaborator Author

I'm going to go ahead and merge this myself since it the current state is "will not render new pages" and it's ultimately just a format fix of a PR that was reviewed in #176

@funnelfiasco funnelfiasco merged commit 0f4d96b into guacsec:main Nov 5, 2024
6 checks passed
@funnelfiasco funnelfiasco deleted the issue175-fix_failure branch November 7, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant