Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDX parser captures version as an artifact for images #2126

Merged
merged 3 commits into from
Sep 18, 2024
Merged

CDX parser captures version as an artifact for images #2126

merged 3 commits into from
Sep 18, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@nathannaveen nathannaveen marked this pull request as draft September 11, 2024 21:03
@nathannaveen
CDX parser captures version as an artifact for images
6f2e645 
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@nathannaveen nathannaveen force-pushed the nathan/updateCDXParsingToCaptureVersion branch from ac3e1d2 to 6f2e645 Compare September 12, 2024 19:51
@nathannaveen nathannaveen marked this pull request as ready for review September 12, 2024 20:07
pxp928
pxp928 approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. minor nit

mihaimaruseac
mihaimaruseac approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after print removal

@pxp928
remove fmt.println and fix lint issue
1e70b16 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 18, 2024
@pxp928
if version is not valid, revert back to using package
20dfc58 
Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 force-pushed the nathan/updateCDXParsingToCaptureVersion branch from 0c79306 to 20dfc58 Compare September 18, 2024 18:49
@kodiakhq kodiakhq bot merged commit 477b1d7 into guacsec:main Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pxp928 pxp928 pxp928 approved these changes

@mihaimaruseac mihaimaruseac mihaimaruseac approved these changes

@lumjjb lumjjb Awaiting requested review from lumjjb

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] CDX parsing to capture version as an artifact for images
3 participants
@nathannaveen @mihaimaruseac @pxp928