Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/endoflife collector #2215

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

robert-cronin
Copy link
Contributor

@robert-cronin robert-cronin commented Oct 25, 2024

Description of the PR

Fixes #2037

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

@robert-cronin robert-cronin force-pushed the feat/endoflife-collector branch 2 times, most recently from 667ebae to f803335 Compare October 25, 2024 01:15
@pxp928 pxp928 added the needs-review Needs writer LGTM label Oct 28, 2024
@lumjjb lumjjb self-requested a review October 28, 2024 15:08
@pxp928 pxp928 requested review from pxp928 and removed request for lumjjb October 28, 2024 15:08
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robert-cronin! This is an amazing PR, very comprehensive. Add a couple comments on implementation into the backend for the new EOL query type, otherwise this is great!

pkg/assembler/graphql/schema/search.graphql Show resolved Hide resolved
cmd/guacone/cmd/eol.go Show resolved Hide resolved
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
Signed-off-by: robert-cronin <robert.owen.cronin@gmail.com>
@robert-cronin
Copy link
Contributor Author

Thanks @robert-cronin! This is an amazing PR, very comprehensive. Add a couple comments on implementation into the backend for the new EOL query type, otherwise this is great!

thanks for the encouragement @pxp928 , really appreciate it! Back to you for round 2

@pxp928
Copy link
Collaborator

pxp928 commented Nov 1, 2024

Thanks! I will look at this soon! Sorry for the delay!

Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is great work! Thank You!

Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kodiakhq kodiakhq bot merged commit 9bbadbc into guacsec:main Nov 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Needs writer LGTM size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Add support for endoflife.date
3 participants