Skip to content

Commit

Permalink
Prepare for building multiple containers
Browse files Browse the repository at this point in the history
  • Loading branch information
philmcmahon committed Oct 3, 2024
1 parent 82d39d6 commit 806739f
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ on:
workflow_dispatch:
push:
paths:
- 'whisper_container/Dockerfile'
- '.github/workflows/build-whisper-docker.yml'
- '../../containers/*'
- '.github/workflows/build-publish-containers.yml'

# Defines two custom environment variables for the workflow. These are used for the Container registry domain, and a name for the Docker image that this workflow builds.
env:
IMAGE_NAME: ${{ github.repository }}
MEDIA_DOWNLOAD_IMAGE_NAME: ${{ github.repository }}_media-download
BUILD_NUMBER: ${{ github.run_number }}
GITHUB_REGISTRY: ghcr.io

Expand Down Expand Up @@ -44,9 +45,6 @@ jobs:
id: meta
uses: docker/metadata-action@v5
with:
images: |
${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}
${{ secrets.TRANSCRIPTION_SERVICE_ECR_URI }}
tags: |
type=sha
type=raw,value=latest
Expand All @@ -61,14 +59,17 @@ jobs:
# This step uses the `docker/build-push-action` action to build the image, based on your repository's `Dockerfile`. If the build succeeds, it pushes the image to GitHub Packages.
# It uses the `context` parameter to define the build's context as the set of files located in the specified path. For more information, see "[Usage](https://github.com/docker/build-push-action#usage)" in the README of the `docker/build-push-action` repository.
# It uses the `tags` and `labels` parameters to tag and label the image with the output from the "meta" step.
- name: Build and push Docker image
- name: Build and push whisper Docker image
uses: docker/build-push-action@v5
with:
context: whisper_container/
file: containers/whisper.Dockerfile
# to add x86: linux/amd64
platforms: linux/arm64
push: true
tags: ${{ steps.meta.outputs.tags }}
tags:
- ${{ steps.meta.outputs.tags }}
- ${{ env.GITHUB_REGISTRY }}/${{ env.IMAGE_NAME }}
- ${{ secrets.TRANSCRIPTION_SERVICE_ECR_URI }}
labels: ${{ steps.meta.outputs.labels }}
cache-from: type=gha
cache-to: type=gha,mode=max
16 changes: 16 additions & 0 deletions containers/media-download.Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
FROM python:3.12-bookworm
WORKDIR /opt
LABEL com.theguardian.transcription-service.media-download-container="Media download container with yt-dlp, associated dependnencies and media download app"

ARG node_version

RUN pip install yt-dlp

RUN apt-get update
RUN apt-get install -y ffmpeg git phantomjs ffprobe nodejs npm
RUN npm install -g n
RUN n $node_version

COPY packages/media-download/dist/index.js /opt/media-download.js

CMD node /opt/media-download.js
File renamed without changes.

0 comments on commit 806739f

Please sign in to comment.