Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 9.12.0.78982 to 9.14.0.81108 #112

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 4, 2023

Bumps SonarAnalyzer.CSharp from 9.12.0.78982 to 9.14.0.81108.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.14

Hello everyone!

We are happy to announce that we now have 5 dedicated Blazor rules 🚀 🥳

Special thanks to our contributor (and former colleague) @​sagi1623 for fixing SonarSource/sonar-dotnet#8302.

Improvements

  • 8274 - [C#] New rule S6797: Query parameter should be of supported type
  • 8278 - [C#] New rule S6798: [JSInvokable] attribute should only be used on public methods
  • 8275 - [C#] New rule S6800: Component parameter type should match the route parameter type constraint
  • 8277 - [C#] New rule S6802: Using lambda expressions in loops should be avoided in Blazor markup section
  • 8338 - [C#] New rule S6803: Parameters with SupplyParameterFromQuery attribute should be used only in routable components
  • 8228 - [C#] Deprecate S4212
  • 8346 - Create CFG from member node
  • 8271 - Adding missing operation wrappers and syntax kinds to the shim layer
  • 8230 - Update Signing Certificate
  • 8290 - Update RSPEC before 9.14 release

Bug Fixes

  • 8310 - [C#, VB.NET] Fix S2068 AD0001: Overflow exception when a configuration file value is a number greater than Int32.MaxValue

False Positive

  • 8285 - [C#, VB.NET] Fix S2583 FP: Number constraint from remainder calculation is not correct.
  • 8358 - [C#] Fix S2743 FP: Arrow properties do not have static fields
  • 7624 - [C#] Fix S3604 FP: Primary constructors

False Negative

  • 8335 - [C#] Fix S2259 FN: FlowCaptures in Field/PropertyReference.Instance
  • 6050 - [C#] Fix S2930 FN: Track System.Threading.CancellationTokenSource

Performance

  • 8181 - [C#] Improve S5332 performance: Reuse compiled regex

9.13

Hello everyone!

We are happy to announce that we now officially support .Net 8 and C# 12 🚀 🥳

Special thanks to our contributor (and former colleague) @​sagi1623 for fixing #8152.

Due to some technical problems, we could not sign the NuGet packages and we did not push them to nuget.org.

Improvements

  • 8234 - [C#, VB.NET] Revert optional plugin support
  • 3682 - [C#, VB.NET] Update S4830: add a message on secondary locations
  • 3694 - [C#] Update S5773: add a message on secondary locations
  • 8159 - Update RSPEC before 9.13 release

Bug Fixes

  • 8024 - [C#] Fix AD0001 in S1144: Implicit object creation inside collection expression

... (truncated)

Commits
  • 1d0f0d9 Update RSPEC before 9.14 release (#8398)
  • 34d8bc8 Fix S3604 FP: Primary constructors (#8390)
  • d338d0d Fix S6802 FP: Reduce scope to raise only within loop blocks (#8387)
  • 9f6edc4 New rule S6797: Blazor query parameter should be of supported type (#8333)
  • 458feb1 ConditionEvaluatesToConstant: SyntaxWalker re-factoring (#8215)
  • 00cd607 Re-enable on demand plugin download for c# and vb.net (#8317)
  • c746b74 S1144: Add repro for #8342 (#8354)
  • 94f71e4 New rule S6802: Using lambda expressions in loops should be avoided in Blazor...
  • 5576421 Fix S2743 FP: Arrow properties do not have static fields (#8364)
  • b69d763 Fix UTs caused by .NET 8 release by using specific nuget version (#8362)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.12.0.78982 to 9.14.0.81108.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.12.0.78982...9.14.0.81108)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget NuGet package packages Packages labels Dec 4, 2023
@dependabot dependabot bot requested a review from guibranco December 4, 2023 05:55
Copy link
Contributor

github-actions bot commented Dec 4, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco
Copy link
Owner

@dependabot squash and merge

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 4, 2023

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@AppVeyorBot
Copy link

@guibranco guibranco enabled auto-merge (squash) December 4, 2023 18:05
@guibranco
Copy link
Owner

@gstraccini review

Copy link
Contributor

gstraccini bot commented Dec 8, 2023

Review enabled! 👀

Copy link

codacy-production bot commented Dec 8, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (27791a7) 565 193 34.16%
Head commit (008208b) 565 (+0) 193 (+0) 34.16% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#112) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (27791a7) 32.92% compared to head (49ff2e6) 32.92%.

❗ Current head 49ff2e6 differs from pull request most recent head 008208b. Consider uploading reports for the commit 008208b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   32.92%   32.92%           
=======================================
  Files          44       44           
  Lines         565      565           
  Branches       26       26           
=======================================
  Hits          186      186           
+ Misses        372      371    -1     
- Partials        7        8    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AppVeyorBot
Copy link

@guibranco guibranco merged commit aa8dc0a into main Dec 8, 2023
20 checks passed
@guibranco guibranco deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.14.0.81108 branch December 8, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget NuGet package packages Packages size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants