Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying reverses with gitauto model #198

Closed

Conversation

gitauto-ai[bot]
Copy link

@gitauto-ai gitauto-ai bot commented Jul 22, 2024

Original issue: #2

What is the feature

Enable querying reverses using V1 API.

Why we need the feature

Currently, the V1 API does not support querying reverses, which limits the functionality and usability of the API for users who need to perform reverse queries. Adding this feature will enhance the API's capabilities and provide a more comprehensive solution for users.

How to implement and why

  1. Define Request and Response Models:

    • Create SearchReverseRequest.cs and SearchReverseResponse.cs in Src/GuiStracini.Mandae/Transport/V1.
    • These models will handle the data structure for the reverse query requests and responses.
  2. Update Client Interface:

    • Modify IMandaeClient.cs to include a method signature for querying reverses.
    • This ensures that any implementation of the client will support reverse queries.
  3. Implement Client Method:

    • Update MandaeClient.cs to implement the new method defined in the interface.
    • This method will handle the logic for making the API call to query reverses.
  4. Service Factory Update:

    • Modify ServiceFactoryV1.cs to include the creation of services related to reverse querying.
    • This ensures that the service factory can provide the necessary services for reverse queries.
  5. Add Unit Tests:

    • Create unit tests in Tests/GuiStracini.Mandae.Tests/V2 to verify the functionality of the reverse querying feature.
    • Ensure that the tests cover various scenarios and edge cases to validate the implementation.

By following these steps, we can ensure that the feature is implemented in a structured and maintainable way, enhancing the API's functionality and providing value to the users.

Test these changes locally

git checkout -b gitauto/issue-#2-be17ed5f-c56b-426e-8da7-3cf88a8bb1e9
git pull origin gitauto/issue-#2-be17ed5f-c56b-426e-8da7-3cf88a8bb1e9

@gstraccini gstraccini bot requested a review from guibranco July 22, 2024 00:11
@gstraccini gstraccini bot added 🚦awaiting triage Awaiting triage 🤖 bot Issue/Pull request created by bot labels Jul 22, 2024
@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.554 failed (commit c18a5e56e9 by @gitauto-ai[bot])

@guibranco guibranco changed the title Fix [FEATURE] Querying reverses with gitauto model Querying reverses with gitauto model Aug 15, 2024
@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.596 failed (commit ad553261fa by @gstraccini[bot])

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.601 failed (commit 3cc10791c2 by @gstraccini[bot])

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.602 failed (commit 7eec9a965b by @gstraccini[bot])

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.604 failed (commit 7eec9a965b by @gstraccini[bot])

@guibranco
Copy link
Owner

@gstraccini appveyor build commit

@guibranco
Copy link
Owner

@gstraccini appveyor build pull request

Copy link
Contributor

gstraccini bot commented Aug 28, 2024

AppVeyor build (pull request) started! 🚀

Build ID: 50495205
Version: 8.0.605

Copy link
Contributor

gstraccini bot commented Aug 28, 2024

AppVeyor build (commit) started! 🚀

Build ID: 50495206
Version: 8.0.606

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.605 failed (commit 7eec9a965b by @gstraccini[bot])

@AppVeyorBot
Copy link

Build GuiStracini.Mandae 8.0.625 failed (commit b7617c9a2a by @gstraccini[bot])

@guibranco guibranco closed this Aug 29, 2024
@guibranco guibranco deleted the gitauto/issue-#2-be17ed5f-c56b-426e-8da7-3cf88a8bb1e9 branch August 29, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚦awaiting triage Awaiting triage 🤖 bot Issue/Pull request created by bot size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants