fixes for comments Bas

gwmod · Apr 19, 2024 · 69ccac7 · 69ccac7
1 parent 367c1a9
commit 69ccac7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -45,7 +45,6 @@ jobs:
           python -c "import nlmod; nlmod.util.download_mfbinaries()"
 
       - name: Run tests only
-        if: ${{ github.event_name == 'pull_request' || github.event_name == 'push'}}
         env:
             NHI_GWO_USERNAME: ${{ secrets.NHI_GWO_USERNAME}}
             NHI_GWO_PASSWORD: ${{ secrets.NHI_GWO_PASSWORD}}

diff --git a/nlmod/dims/grid.py b/nlmod/dims/grid.py
@@ -238,9 +238,10 @@ def modelgrid_from_ds(ds, rotated=True, nlay=None, top=None, botm=None, **kwargs
 def modelgrid_to_vertex_ds(mg, ds, nodata=-1):
     """Add information about the calculation-grid to a model dataset."""
 
-    logger.warning(
+    warnings.warn(
         "'modelgrid_to_vertex_ds' is deprecated and will be removed in a"
-        "future version, please use 'modelgrid_to_ds' instead"
+        "future version, please use 'modelgrid_to_ds' instead",
+        DeprecationWarning,
     )
 
     # add modelgrid to ds