Skip to content

Commit

Permalink
Incomplete knmi ts breaks get_recharge function (#269)
Browse files Browse the repository at this point in the history
* Incomplete knmi ts breaks get_recharge function

Solution provided by Davíd.

By setting fill_missing_obs missing values are filled with nearby time series

* pin hydropandas to newest version (with option to fill missing obs in evp)

* version bump

---------

Co-authored-by: OnnoEbbens <onnoebbens@gmail.com>
  • Loading branch information
bdestombe and OnnoEbbens authored Oct 18, 2023
1 parent 40989db commit 7b72aec
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions nlmod/read/knmi.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,11 @@ def get_knmi_at_locations(ds, start="2010", end=None, most_common_station=False)

# get knmi data stations closest to any grid cell
oc_knmi_prec = hpd.ObsCollection.from_knmi(
stns=stns_rd, starts=[start], ends=[end], meteo_vars=["RD"]
stns=stns_rd, starts=[start], ends=[end], meteo_vars=["RD"], fill_missing_obs=True
)

oc_knmi_evap = hpd.ObsCollection.from_knmi(
stns=stns_ev24, starts=[start], ends=[end], meteo_vars=["EV24"]
stns=stns_ev24, starts=[start], ends=[end], meteo_vars=["EV24"], fill_missing_obs=True
)

return locations, oc_knmi_prec, oc_knmi_evap
2 changes: 1 addition & 1 deletion nlmod/version.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from importlib import metadata
from platform import python_version

__version__ = "0.6.2b"
__version__ = "0.7.0"


def show_versions() -> None:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies = [
"affine>=0.3.1",
"geopandas",
"owslib>=0.24.1",
"hydropandas>=0.7.1",
"hydropandas>=0.9.2",
"shapely>=2.0.0",
"pyshp>=2.1.3",
"matplotlib",
Expand Down

0 comments on commit 7b72aec

Please sign in to comment.