Update webservices.py #314
Conversation
Two issues are solved: - If values for a large area are prompted, the query url gets very long and is not accepted by HHNK polderpeil server. Is now queried in chunks - An error in the database of HHNK resulted in duplicate peil definitions. Only use the unambigious entries and leave a note in the logs.
|
Hi Ruben, |
|
OK, sorry for the blunt comment then. Let's continue the way you propose, and think of an approach to seperate the waterboard-specific information in the future. @OnnoEbbens has some weeks off, so we can better wait unitil he is back with large changes. We can merge this PR I think. |
|
Ah I understand. I should have put the logic for waterboards in waterboards.py and not in webservices.py. I don't remember why I did that. I can fix this, but unfortunately not anytime soon. For now we can merge this as a quick fix and leave an issue open for me to fix this correctly later. |
|
Oh no, there were no harsh feelings or what so ever. I just didn't have an
idea ready to solve the problem you brought up.
Do the commits of Onno and me break the function when used for other
waterboards?
…On Tue, Jan 23, 2024, 17:29 Ruben Caljé ***@***.***> wrote:
OK, sorry for the blunt comment then. Let's continue the way you propose,
and think of an approach to seperate the waterboard-specific information in
the future. @OnnoEbbens <https://github.com/OnnoEbbens> has some weeks
off, so we can better wait unitil he is back with large changes. We can
merge this PR I think.
—
Reply to this email directly, view it on GitHub
<#314 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACWF3BK6GMMMI7JGBI6P64TYP7QN3AVCNFSM6AAAAABCGXVLRSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBWGQZTOOBWGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
No harsh feelings from me either :) I think the arcrest function is only used in waterboards.py so it should not break anything. @rubencalje: please correct me if I am wrong |
Two issues are solved: