Add support for NHI GWO database #319
Conversation
with extraction data
| assert len(empty_lines) == 2 | ||
|
|
||
| # read properties | ||
| skiprows = list(range(empty_lines[0] + 1)) + [empty_lines[0] + 2] |
There was a problem hiding this comment.
Is this hard-coded 100 guaranteed to always work?
There was a problem hiding this comment.
Comment got moved I see, the line in question is a few lines before.
There was a problem hiding this comment.
If there are less than 100 lines in the returned content, this code still works.
However, there are some situations, where no wells or measurements are found, that will give an unclear error, that is not caught yet. I will try to fix this.
There was a problem hiding this comment.
But there may be more than 100 wells, then this will fail... I removed the 100
|
|
||
|
|
||
| @pytest.mark.skip("too slow") | ||
| def test_gwo_entire_pumping_station(): |
There was a problem hiding this comment.
out of curiosity, how long does this request take?
There was a problem hiding this comment.
Not long, a few seconds, but does not test any new lines. But wanted to store this usefull code somewhere.
Add checks for empty empty content Determine empty lines in get_gwo_wells, to be used in skiprows
This pull request adds support for the NHI GWO databse with extraction data in the Netherlands, mainly form drinking water companies:
https://gwo.nhi.nu/
Users should register at this website to obtain a username and password. For testing purposes, I added my username and password to the Github-secrets, which are used by the tests.