Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cache.py #326

Merged
merged 13 commits into from
Apr 15, 2024
Merged

Update cache.py #326

merged 13 commits into from
Apr 15, 2024

Commits on Feb 20, 2024

  1. Update cache.py

    The netcdf cache function validates the cache by comparing the ds argument and other function arguments to the pickled arguments. If they match, the cache can be used.
    
    Currently, just the coordinates of the argument ds and the output ds had to match, introducing two errors:
    - If the data_vars differ and are used the cache is falsely valid
    - The coordintates of the ds argument has to match the coordinates of the output ds. This limits the use of the cache function.
    
    The PR compares the hash of the coords and data_vars of the ds argument to those that were stored in the pickle together with the cached output ds.
    
    Ideally, the cache.cache_netcdf() accepts arguments that specify specifically which data_vars and coords need to be included in the validation check. Beyond the scope of this pr.
    bdestombe authored Feb 20, 2024
    Configuration menu
    Copy the full SHA
    f9fbffd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea6821f View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Configuration menu
    Copy the full SHA
    d6b1421 View commit details
    Browse the repository at this point in the history
  2. Update cache.py

    bdestombe committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    66ccfac View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Configuration menu
    Copy the full SHA
    65011b7 View commit details
    Browse the repository at this point in the history
  2. Removed white spaces

    bdestombe committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    89c007b View commit details
    Browse the repository at this point in the history
  3. Remove white space

    bdestombe committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    bf35038 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Removing more whitespace

    bdestombe committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    863a8ff View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Configuration menu
    Copy the full SHA
    82586d9 View commit details
    Browse the repository at this point in the history
  2. Removed whitespace

    bdestombe committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    ed89972 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad324cb View commit details
    Browse the repository at this point in the history
  4. Removed more white space

    bdestombe committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e1fc0d8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    bd81e00 View commit details
    Browse the repository at this point in the history