-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cache.py #326
Merged
Merged
Update cache.py #326
Commits on Feb 20, 2024
-
The netcdf cache function validates the cache by comparing the ds argument and other function arguments to the pickled arguments. If they match, the cache can be used. Currently, just the coordinates of the argument ds and the output ds had to match, introducing two errors: - If the data_vars differ and are used the cache is falsely valid - The coordintates of the ds argument has to match the coordinates of the output ds. This limits the use of the cache function. The PR compares the hash of the coords and data_vars of the ds argument to those that were stored in the pickle together with the cached output ds. Ideally, the cache.cache_netcdf() accepts arguments that specify specifically which data_vars and coords need to be included in the validation check. Beyond the scope of this pr.
Configuration menu - View commit details
-
Copy full SHA for f9fbffd - Browse repository at this point
Copy the full SHA f9fbffdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea6821f - Browse repository at this point
Copy the full SHA ea6821fView commit details
Commits on Mar 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d6b1421 - Browse repository at this point
Copy the full SHA d6b1421View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66ccfac - Browse repository at this point
Copy the full SHA 66ccfacView commit details
Commits on Apr 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 65011b7 - Browse repository at this point
Copy the full SHA 65011b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89c007b - Browse repository at this point
Copy the full SHA 89c007bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf35038 - Browse repository at this point
Copy the full SHA bf35038View commit details
Commits on Apr 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 863a8ff - Browse repository at this point
Copy the full SHA 863a8ffView commit details
Commits on Apr 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 82586d9 - Browse repository at this point
Copy the full SHA 82586d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed89972 - Browse repository at this point
Copy the full SHA ed89972View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad324cb - Browse repository at this point
Copy the full SHA ad324cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e1fc0d8 - Browse repository at this point
Copy the full SHA e1fc0d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for bd81e00 - Browse repository at this point
Copy the full SHA bd81e00View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.