Improve export to ugrid_nc-file, to support imod qgis plugin #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnnoEbbens
approved these changes
Mar 11, 2024
nlmod/gis.py
Outdated
| @@ -335,13 +339,24 @@ def ds_to_ugrid_nc_file( | |||
| face_node_connectivity : str, optional | |||
| The name of the variable that contains the indexes of the vertices for | |||
| each face. The default is 'icvert'. | |||
| split_layer_dimension : bool, optional | |||
| Splits the layer dimension into seperate varibales when True. The defaults is | |||
There was a problem hiding this comment.
varibales -> variables
nlmod/gis.py
Outdated
| Splits the layer dimension into seperate varibales when True. The defaults is | ||
| True. | ||
| split_time_dimension : bool, optional | ||
| Splits the time dimension into seperate varibales when True. The defaults is |
|
Tests fail unrelated to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.