Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with display of Tools data on Homepage and Projects page #5380

Merged

Conversation

davidwiese
Copy link
Member

Fixes #5321

What changes did you make?

  • Fixed indentation of the project-tools div to match the others in the section
  • Refactored the ${project.tools} code to place a comma and space between each tool, similar to the project languages and project technologies
  • Confirmed with Docker that the Tools data renders as expected on both pages, and didn't notice any unexpected changes

Why did you make the changes (we will use this info to test)?

  • So that the website better demonstrates professionalism and attention to detail to our visitors

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b davidwiese-fix-bug-display-tools-data-5321 gh-pages
git pull https://github.com/davidwiese/website.git fix-bug-display-tools-data-5321

@github-actions github-actions bot added Bug Something isn't working role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium time sensitive Needs to be worked on by a particular timeframe P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ size: 0.5pt Can be done in 3 hours or less labels Aug 30, 2023
@t-will-gillis
Copy link
Member

available & eta: 8/31

@roslynwythe roslynwythe self-requested a review August 31, 2023 06:10
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @davidwiese for prompt and professional work on this time-sensitive issue. Your code change is correct and elegant, the PR is well-formed and descriptive and checks out in the browser on these project pages: Access the Data, Brigade Organizers Playbook, Food Oasis, website.

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidwiese Fantastic work! You have the bases covered: the branches are correct, the PR is linked to the original issue, the description explains exactly what you did and why, and the screenshots demonstrate the edits were successful. Your code is clean and concise. Thanks for taking up this issue!

@t-will-gillis t-will-gillis merged commit be141ca into hackforla:gh-pages Aug 31, 2023
10 checks passed
@davidwiese davidwiese deleted the fix-bug-display-tools-data-5321 branch September 1, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Complexity: Medium P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix bug with display of Tools data on Homepage and Projects page
3 participants