Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github-handle for Natalie Aguilar in tech-work-experience.md #7405

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from

Conversation

rachelcorawood
Copy link
Member

Fixes #7252

What changes did you make?
-added "github-handle:" under Natalie Aguilar name in Tech Work Experience Project (tech-work-experience.md)

Why did you make the changes (we will use this info to test)?
-We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website.

Copy link

github-actions bot commented Sep 6, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rachelcorawood-add-githubHandle-7252 gh-pages
git pull https://github.com/rachelcorawood/website.git add-githubHandle-7252

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 6, 2024
@codyyjxn codyyjxn self-requested a review September 6, 2024 15:39
codyyjxn
codyyjxn previously approved these changes Sep 6, 2024
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @rachelcorawood
Everything looks good! Thank you for taking this issue on.

For future reference

  • the removal of some whitespace, which I don't believe should affect the functionality. However, it's always a good precaution to double-check where the whitespace was removed to ensure it doesn't impact the code in any way.

  • In the pr you can also add the name you changed.

@rachelcorawood
Copy link
Member Author

Hi @codyyjxn Thank you! I'm all set right? I don't need to personal take any further actions for this issue or pull request correct?

@t-will-gillis t-will-gillis removed the request for review from ziniwang September 7, 2024 17:54
@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 7, 2024

@rachelcorawood

  • Since this is a duplicate PR, the PR that is being replaced needs to be closed with a comment linking to this new PR.
  • Please do not assign reviewers***, even if GitHub suggests someone. The person that you assigned is no longer active on the Website team, so you will be waiting a long time for a review from that person. ***The only exceptions are if you already arranged for a review from that person, or if that person previously reviewed the same PR: in other words, you should request reviews from @8alpreet, @daras-cu, and @minkang3

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rachelcorawood, it looks like you are still having the same issue with additional lines being edited to remove whitespace. While it doesn't affect the code itself, if it's something your code editor is doing automatically it will keep coming up in future contributions you make so it is best to resolve it now. You can see where the additional edits are in the "Files changed" tab at the top of your PR. You may need to adjust your editor settings or check what extensions you have enabled.

Everything else looks good, your PR is set up correctly and you added the github-handle variable as required.

@DrAcula27
Copy link
Member

@rachelcorawood It looks like changes were requested before this PR can be approved.

  • If you have made these changes, please scroll up to the top of this page, and in the right-hand column, where it shows the reviewers, click on the Re-request review button next to the red icon.
  • If you have not made the requested changes yet and need help figuring out the settings to prevent your editor from automatically making these whitespace changes, feel free to shoot me a message on Slack. As mentioned by the previous reviewers, this whitespace change here doesn't meaningfully change the code, however, in future issues this could pose a problem, especially with file types where whitespace matters.

@t-will-gillis
Copy link
Member

Hi @rachelcorawood Please leave an update on when you will be able to complete this PR. Thank you

@rachelcorawood
Copy link
Member Author

Hi @t-will-gillis I should have this done by late this evening. I will be attending the meeting from 7:30-8pm. I hit a block with updating my branch. At this point I may create a third branch to complete this task because I've hit some unexpected challenges. I'm gonna attend tonight's meeting to see if I can remedy the problem before I do so.

@DrAcula27 DrAcula27 self-requested a review September 27, 2024 02:07
@jazxbx jazxbx requested review from jazxbx and removed request for jazxbx September 27, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Status: test-pending-approval (Automated Column, do not place items here manually)
Development

Successfully merging this pull request may close these issues.

Add github-handle for Natalie Aguilar in tech-work-experience.md
5 participants