-
-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github-handle for Natalie Aguilar in tech-work-experience.md #7405
base: gh-pages
Are you sure you want to change the base?
Add github-handle for Natalie Aguilar in tech-work-experience.md #7405
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @rachelcorawood
Everything looks good! Thank you for taking this issue on.
For future reference
-
the removal of some whitespace, which I don't believe should affect the functionality. However, it's always a good precaution to double-check where the whitespace was removed to ensure it doesn't impact the code in any way.
-
In the pr you can also add the name you changed.
Hi @codyyjxn Thank you! I'm all set right? I don't need to personal take any further actions for this issue or pull request correct? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rachelcorawood, it looks like you are still having the same issue with additional lines being edited to remove whitespace. While it doesn't affect the code itself, if it's something your code editor is doing automatically it will keep coming up in future contributions you make so it is best to resolve it now. You can see where the additional edits are in the "Files changed" tab at the top of your PR. You may need to adjust your editor settings or check what extensions you have enabled.
Everything else looks good, your PR is set up correctly and you added the github-handle
variable as required.
@rachelcorawood It looks like changes were requested before this PR can be approved.
|
Hi @rachelcorawood Please leave an update on when you will be able to complete this PR. Thank you |
Hi @t-will-gillis I should have this done by late this evening. I will be attending the meeting from 7:30-8pm. I hit a block with updating my branch. At this point I may create a third branch to complete this task because I've hit some unexpected challenges. I'm gonna attend tonight's meeting to see if I can remedy the problem before I do so. |
Fixes #7252
What changes did you make?
-added "github-handle:" under Natalie Aguilar name in Tech Work Experience Project (tech-work-experience.md)
Why did you make the changes (we will use this info to test)?
-We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
No visual changes to the website.