-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first commit, updated leadership #7498
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
availability: 5-6pm Mon-Fri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@NolaDodd Thank you for taking on this issue.
I noticed a few things regarding the recent updates:
-
The branch name includes an incorrect issue number. The correct issue is linked in the title, but it would be great if the branch name could reflect that as well.
-
I ran your branch locally and compared it to the current state of the Communities of Practice website. It seems there aren't any visual changes between the two. Could you double-check to ensure the updates were applied correctly?
-
The issue mentions adding the [Insert name of project] page, so this should be reflected in the title as well. Instead of "First commit, updated leadership," could you revise the title to better align with the task?
If you have any questions or anything that needs to be clarified please feel free to message me back. Thanks!
availability: 5am-6pm Mon>Sun |
availability: Mon-Sun, 5pm-9pm PST |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NolaDodd
What you did correctly:
- clearly stated changes made and why they were made
- displayed visual changes for before and after (I ran it in my local environment and the differences are visible). I recommend double-checking and letting the reviewers know if there doesn't seem to be anything wrong.
Requested changes:
- your branch is incorrectly named by its issue #
- the PR title is slightly unclear and could be improved to better describe the changes you are made! I suggest keeping your branch name and PR title similar as well.
Other than that, you did great! Let me know if you have any questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NolaDodd, thanks for taking on this issue!
Things you did great:
- Screenshots accurately show changes from current site to proposed changes
- Correctly linked issue in PR
- Accurate description of changes made w/ reference to file location
- Excellent description of why you made these changes
Things to work on:
- More descriptive branch name. The currently name makes unclear whether you're adding or removing something. Try something more in like with your reason as to why you made the changes
- Use present tense in your PR title
Congrats on your first commit! Please ask for a re-review when these changes are done!
I'm gonna go ahead and make a new pull request to correct some of the changes since I also need to change the branch name. Thanks for the feedback everyone! |
Fixes #7497
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied