Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit, updated leadership #7498

Closed

Conversation

NolaDodd
Copy link
Member

@NolaDodd NolaDodd commented Sep 19, 2024

Fixes #7497

What changes did you make?

  • deleted the original "leadership" variable as shown in the issue in file _data/internal/communities/ops.yml
  • replaced with the new "leadership" variable that was given

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information. The leaders for the DevOps team needed to be updated.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

Screenshot 2024-09-19 142506

Visuals after changes are applied

Screenshot 2024-09-19 142751

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b NolaDodd-add-remove-leaders-7294 gh-pages
git pull https://github.com/NolaDodd/website.git add-remove-leaders-7294

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 19, 2024
@FamousHero FamousHero self-requested a review September 19, 2024 23:14
@FamousHero
Copy link
Member

availability: 5-6pm Mon-Fri
eta: EOD 9/23

@codyyjxn codyyjxn self-requested a review September 19, 2024 23:50
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NolaDodd Thank you for taking on this issue.

I noticed a few things regarding the recent updates:

  • The branch name includes an incorrect issue number. The correct issue is linked in the title, but it would be great if the branch name could reflect that as well.

  • I ran your branch locally and compared it to the current state of the Communities of Practice website. It seems there aren't any visual changes between the two. Could you double-check to ensure the updates were applied correctly?

  • The issue mentions adding the [Insert name of project] page, so this should be reflected in the title as well. Instead of "First commit, updated leadership," could you revise the title to better align with the task?

If you have any questions or anything that needs to be clarified please feel free to message me back. Thanks!

@codyyjxn
Copy link
Member

availability: 5am-6pm Mon>Sun
eta: EOD 9/19

@terrencejihoonjung
Copy link
Member

availability: Mon-Sun, 5pm-9pm PST
eta: 9/20/24, 11:59pm PST

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NolaDodd

What you did correctly:

  • clearly stated changes made and why they were made
  • displayed visual changes for before and after (I ran it in my local environment and the differences are visible). I recommend double-checking and letting the reviewers know if there doesn't seem to be anything wrong.

Requested changes:

  • your branch is incorrectly named by its issue #
  • the PR title is slightly unclear and could be improved to better describe the changes you are made! I suggest keeping your branch name and PR title similar as well.

Other than that, you did great! Let me know if you have any questions.

Copy link
Member

@FamousHero FamousHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NolaDodd, thanks for taking on this issue!

Things you did great:

  • Screenshots accurately show changes from current site to proposed changes
  • Correctly linked issue in PR
  • Accurate description of changes made w/ reference to file location
  • Excellent description of why you made these changes

Things to work on:

  • More descriptive branch name. The currently name makes unclear whether you're adding or removing something. Try something more in like with your reason as to why you made the changes
  • Use present tense in your PR title

Congrats on your first commit! Please ask for a re-review when these changes are done!

@NolaDodd
Copy link
Member Author

I'm gonna go ahead and make a new pull request to correct some of the changes since I also need to change the branch name. Thanks for the feedback everyone!

@NolaDodd NolaDodd closed this Sep 21, 2024
@NolaDodd NolaDodd deleted the add-remove-leaders-7294 branch September 21, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update CoP: Ops: Add and Remove leaders
4 participants