-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create python-package.yml #741
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis PR adds a GitHub Actions workflow configuration file that sets up automated testing and linting for a Python project. The workflow runs on Ubuntu and tests against Python versions 3.9, 3.10, and 3.11. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ATMFEEDME20z - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider upgrading actions/setup-python from v3 to v4 to get the latest features and security updates
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟡 Security: 1 issue found
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Set up Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚨 suggestion (security): Consider upgrading to actions/setup-python@v4
Version 4 includes security updates and performance improvements that would benefit the workflow.
uses: actions/setup-python@v3 | |
uses: actions/setup-python@v4 |
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9", "3.10", "3.11"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): Consider adding Python 3.12 to the test matrix
Python 3.12 is now stable and adding it would ensure compatibility with the latest Python version.
python-version: ["3.9", "3.10", "3.11"] | |
python-version: ["3.9", "3.10", "3.11", "3.12"] |
Summary by Sourcery
CI: