Skip to content

Commit

Permalink
Add clarification about direction of slowness
Browse files Browse the repository at this point in the history
  • Loading branch information
halleysfifthinc committed Aug 23, 2024
1 parent e28e804 commit dcf1135
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,18 +59,18 @@ jobs:
version: '1'
- uses: julia-actions/cache@v1
- run: |
julia --project=docs -e '
julia --color=auto --project=docs -e '
using Pkg
Pkg.Registry.update()
Pkg.develop(PackageSpec(path=pwd()))
Pkg.instantiate()'
- run: |
julia --project=docs -e '
julia --color=auto --project=docs -e '
using Documenter: DocMeta, doctest
using Peaks
DocMeta.setdocmeta!(Peaks, :DocTestSetup, :(using Peaks); recursive=true)
doctest(Peaks)'
- run: julia --project=docs docs/make.jl
- run: julia --color=auto --project=docs docs/make.jl
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
DOCUMENTER_KEY: ${{ secrets.DOCUMENTER_KEY }}
3 changes: 2 additions & 1 deletion docs/src/benchmarks.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ variably[^2].
function; more predictable branches will make the function run faster than could be
expected with more realistic data.

When benchmarking against randomly sampled data, we see roughly the same performance characteristics, now presented relative to the speed of `simplemaxima`:
When benchmarking against randomly sampled data, we see roughly the same performance
characteristics, now presented relative to the speed of `simplemaxima` (higher is slower):

```@example benchmark_plots
ratio_plot # hide
Expand Down

2 comments on commit dcf1135

@halleysfifthinc
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/113698

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.3 -m "<description of version>" dcf11356811627ee3dab397be22c818017445180
git push origin v0.5.3

Please sign in to comment.